Do not use unaffiliated users' connections for device policy pushing

Do not use unaffiliated users' connections for device policy pushing

Device policy pushing requires a connected invalidation service. When
a user logs in, an invalidation service is typically spun up for the
user. Device policy pushing can reuse this service instead of running
its own invalidation service to conserve server resources.

This CL ensures that for privacy reasons, device policy pushing only
reuses the user's invalidation service if the user is affiliated with
the device.

BUG=415094
TEST=New unit test

Committed: https://crrev.com/6c34217875d95449ac888b490cc684832d38c3c4
Cr-Commit-Position: refs/heads/master@{#295483}

[bartfab (slow), 2014-09-17 11:53:08]

bartfab@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[bartfab (slow), 2014-09-17 11:53:08]

Hi Julian,

Could you take a look please?

[pastarmovj, 2014-09-17 16:04:57]

LGTM with a nit/request.

https://codereview.chromium.org/567393006/diff/1/chrome/browser/chromeos/poli...
File chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc
(right):

https://codereview.chromium.org/567393006/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc:389:
TEST_F(DeviceCloudPolicyInvalidatorTest, SwitchInvalidationServices) {
nit: This is a GIANT test. Is there any chance you can split this into few
smaller ones. I think if this test fails it will be hard to fix the issue
because the first failed ASSERT can hide more errors along the test. I don't
have enough context to say if this is feasible but it will be great if it is.

[bartfab (slow), 2014-09-18 15:42:53]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-09-18 15:44:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/567393006/20001

[bartfab (slow), 2014-09-18 15:50:41]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-09-18 15:51:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/567393006/40001

[commit-bot: I haz the power, 2014-09-18 16:46:17]

Committed patchset #3 (id:40001) as e32e26b7bc9764a5b83afdf272dca80b3839dd3e

[commit-bot: I haz the power, 2014-09-18 16:47:21]

Patchset 3 (id:??) landed as
https://crrev.com/6c34217875d95449ac888b490cc684832d38c3c4
Cr-Commit-Position: refs/heads/master@{#295483}