Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 567393004: gn: don't remove -fno-exceptions to match gyp (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M BUILD.gn View 13 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
6 years, 3 months ago (2014-09-17 00:33:44 UTC) #1
jam
lgtm
6 years, 3 months ago (2014-09-18 01:23:56 UTC) #2
scottmg
6 years, 3 months ago (2014-09-18 16:29:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 9135010 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698