Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 567393002: Change SkResourceCache to take a Visitor inside its find(). (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
danakj, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Change SkResourceCache to take a Visitor inside its find(). This simplifies the API/contract, in that there are not any exposed lock/unlock scopes. patch from issue 572573002 BUG=skia: Committed: https://skia.googlesource.com/skia/+/dee6a8e67db39fcbde2b3bb09be1d088ebb9db8a

Patch Set 1 #

Patch Set 2 : document Find and Visitor, cast directly between ref types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -177 lines) Patch
M bench/ImageCacheBench.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkBitmapCache.cpp View 1 4 chunks +20 lines, -23 lines 0 comments Download
M src/core/SkResourceCache.h View 1 6 chunks +33 lines, -16 lines 0 comments Download
M src/core/SkResourceCache.cpp View 5 chunks +15 lines, -105 lines 0 comments Download
M tests/ImageCacheTest.cpp View 1 2 chunks +23 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
6 years, 3 months ago (2014-09-15 13:14:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567393002/20001
6 years, 3 months ago (2014-09-15 13:38:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-15 13:38:09 UTC) #5
mtklein
lgtm
6 years, 3 months ago (2014-09-15 13:41:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as dee6a8e67db39fcbde2b3bb09be1d088ebb9db8a
6 years, 3 months ago (2014-09-15 13:44:50 UTC) #7
reed1
6 years, 3 months ago (2014-09-15 17:14:41 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/569303002/ by reed@google.com.

The reason for reverting is: crashes on android bots, haven't diagnosed yet.

Powered by Google App Engine
This is Rietveld 408576698