Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 567333002: Reland "Use unsigned type bitsets to limit undefined behaviour" (Closed)

Created:
6 years, 3 months ago by rossberg
Modified:
6 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Use unsigned type bitsets to limit undefined behaviour" Temporary debug attempt; adds output to failing test in test-types.cc, otherwise unchanged. Windows f R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -156 lines) Patch
M src/types.h View 11 chunks +76 lines, -76 lines 0 comments Download
M src/types.cc View 20 chunks +59 lines, -50 lines 0 comments Download
M src/types-inl.h View 5 chunks +14 lines, -11 lines 0 comments Download
M test/cctest/test-types.cc View 10 chunks +28 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 3 months ago (2014-09-15 09:25:03 UTC) #1
ulan
lgtm
6 years, 3 months ago (2014-09-15 09:35:27 UTC) #2
rossberg
6 years, 3 months ago (2014-09-15 09:40:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698