 Chromium Code Reviews
 Chromium Code Reviews Issue 567313003:
  RegExp: Add support for the ES6-proposed sticky flag  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 567313003:
  RegExp: Add support for the ES6-proposed sticky flag  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/jsregexp.cc | 
| diff --git a/src/jsregexp.cc b/src/jsregexp.cc | 
| index 0d9f83af37ba48b7ee7b2cf24e81e3ed34d151ab..b4c82cb85fd1e1bb87a9e2993b24ac388caf71ee 100644 | 
| --- a/src/jsregexp.cc | 
| +++ b/src/jsregexp.cc | 
| @@ -70,6 +70,9 @@ static JSRegExp::Flags RegExpFlagsFromString(Handle<String> str) { | 
| case 'm': | 
| flags |= JSRegExp::MULTILINE; | 
| break; | 
| + case 'y': | 
| + if (FLAG_harmony_regexps) flags |= JSRegExp::STICKY; | 
| + break; | 
| } | 
| } | 
| return JSRegExp::Flags(flags); | 
| @@ -185,12 +188,14 @@ MaybeHandle<Object> RegExpImpl::Compile(Handle<JSRegExp> re, | 
| if (parse_result.simple && | 
| !flags.is_ignore_case() && | 
| + !flags.is_sticky() && | 
| !HasFewDifferentCharacters(pattern)) { | 
| // Parse-tree is a single atom that is equal to the pattern. | 
| AtomCompile(re, pattern, flags, pattern); | 
| has_been_compiled = true; | 
| } else if (parse_result.tree->IsAtom() && | 
| !flags.is_ignore_case() && | 
| + !flags.is_sticky() && | 
| parse_result.capture_count == 0) { | 
| RegExpAtom* atom = parse_result.tree->AsAtom(); | 
| Vector<const uc16> atom_pattern = atom->data(); | 
| @@ -430,7 +435,8 @@ bool RegExpImpl::CompileIrregexp(Handle<JSRegExp> re, | 
| } | 
| RegExpEngine::CompilationResult result = RegExpEngine::Compile( | 
| &compile_data, flags.is_ignore_case(), flags.is_global(), | 
| - flags.is_multiline(), pattern, sample_subject, is_one_byte, &zone); | 
| + flags.is_multiline(), flags.is_sticky(), pattern, sample_subject, | 
| + is_one_byte, &zone); | 
| if (result.error_message != NULL) { | 
| // Unable to compile regexp. | 
| Handle<String> error_message = isolate->factory()->NewStringFromUtf8( | 
| @@ -6025,8 +6031,8 @@ void DispatchTableConstructor::VisitAction(ActionNode* that) { | 
| RegExpEngine::CompilationResult RegExpEngine::Compile( | 
| RegExpCompileData* data, bool ignore_case, bool is_global, | 
| - bool is_multiline, Handle<String> pattern, Handle<String> sample_subject, | 
| - bool is_one_byte, Zone* zone) { | 
| + bool is_multiline, bool is_sticky, Handle<String> pattern, | 
| + Handle<String> sample_subject, bool is_one_byte, Zone* zone) { | 
| if ((data->capture_count + 1) * 2 - 1 > RegExpMacroAssembler::kMaxRegister) { | 
| return IrregexpRegExpTooBig(zone->isolate()); | 
| } | 
| @@ -6053,7 +6059,7 @@ RegExpEngine::CompilationResult RegExpEngine::Compile( | 
| bool is_end_anchored = data->tree->IsAnchoredAtEnd(); | 
| bool is_start_anchored = data->tree->IsAnchoredAtStart(); | 
| int max_length = data->tree->max_match(); | 
| - if (!is_start_anchored) { | 
| + if (!is_start_anchored && !is_sticky) { | 
| // Add a .*? at the beginning, outside the body capture, unless | 
| // this expression is anchored at the beginning. | 
| 
Yang
2014/09/15 09:23:16
... or sticky.
 
Erik Corry
2014/09/16 17:49:40
Done.
 | 
| RegExpNode* loop_node = |