RegExp: Add support for the ES6-proposed sticky flag

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/code-stubs.h"
 #include "src/extensions/externalize-string-extension.h"
 #include "src/extensions/free-buffer-extension.h"
@@ skipping 1399 matching lines @@
         *strict_generator_function_map);
 
     Handle<JSFunction> object_function(native_context()->object_function());
     Handle<Map> generator_object_prototype_map = Map::Create(
         object_function, 0);
     generator_object_prototype_map->set_prototype(
         *generator_object_prototype);
     native_context()->set_generator_object_prototype_map(
         *generator_object_prototype_map);
   }
+  v8::Isolate* external_isolate = reinterpret_cast<v8::Isolate*>(isolate());
+  v8::Local<v8::Boolean> flag = FLAG_harmony_regexps ?
+                                v8::True(external_isolate) :
+                                v8::False(external_isolate);

[Yang, 2014/09/17 07:16:14]

Let's not unnecessarily use API handles. We can just have 

    Runtime::DefineObjectProperty(
        builtins,
       
factory()->InternalizeOneByteString(STATIC_CHAR_VECTOR("harmony_regexps")),
        isolate()->heap()->ToBoolean(FLAG_harmony_regexps), NONE).Assert();

I assume you took the code from Genesis::Genesis. There is no internal way to
initialize a typed array, which is why API methods are used there.

[Erik Corry, 2014/09/17 17:06:19]

Done.

+  Handle<JSBuiltinsObject> builtins(native_context()->builtins());
+  Runtime::DefineObjectProperty(builtins,
+                                factory()->InternalizeOneByteString(
+                                    STATIC_CHAR_VECTOR("harmony_regexps")),
+                                Utils::OpenHandle(*flag), NONE).Assert();
 }
 
 
 bool Genesis::CompileBuiltin(Isolate* isolate, int index) {
   Vector<const char> name = Natives::GetScriptName(index);
   Handle<String> source_code =
       isolate->bootstrapper()->NativesSourceLookup(index);
   return CompileNative(isolate, name, source_code);
 }
 
@@ skipping 1295 matching lines @@
   return from + sizeof(NestingCounterType);
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 } }  // namespace v8::internal