Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 567293005: Fix V1 app crash when verifying sockets API is available. (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix V1 app crash when verifying sockets API is available. the code that checks that sockets API is available was checking that chrome.socket.secure is defined without verifying that chrome.socket is defined. As result the app would not connect. BUG=414366 Committed: https://crrev.com/efb18cbb572a9c798c6ef6c81a0a6cb54935814d Cr-Commit-Position: refs/heads/master@{#295183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/session_connector.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-15 18:35:28 UTC) #2
kelvinp
lgtm
6 years, 3 months ago (2014-09-15 18:44:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567293005/1
6 years, 3 months ago (2014-09-15 20:05:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56112) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/60991) android_arm64_dbg_recipe ...
6 years, 3 months ago (2014-09-15 20:32:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567293005/1
6 years, 3 months ago (2014-09-16 01:11:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/14513)
6 years, 3 months ago (2014-09-16 02:23:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567293005/1
6 years, 3 months ago (2014-09-16 23:47:32 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as e17a39cfca316d324bada0e28851c56f0a035961
6 years, 3 months ago (2014-09-17 00:16:59 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:17:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efb18cbb572a9c798c6ef6c81a0a6cb54935814d
Cr-Commit-Position: refs/heads/master@{#295183}

Powered by Google App Engine
This is Rietveld 408576698