Add exc_client_variants (UniversalRaiseException()) and its test

Add exc_client_variants (UniversalExceptionRaise()) and its test.

This also puts kMachExceptionCodes into mach_extensions.h, because a
form of MACH_EXCEPTION_CODES that’s the right type
(exception_behavior_t) has now shown its use in more than one file.

TEST=util_test ExcClientVariants.UniversalExceptionRaise
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1e7cdb30a04ced7cca62b6da3ac3a26a9ba981f2

[Mark Mentovai, 2014-09-14 22:02:15]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2014-09-15 20:55:44]

https://codereview.chromium.org/567283002/diff/20001/util/mach/exc_client_var...
File util/mach/exc_client_variants.h (right):

https://codereview.chromium.org/567283002/diff/20001/util/mach/exc_client_var...
util/mach/exc_client_variants.h:62: //!     order to be passed to the
appropriate exception handler.
I assume it's deliberate to not document all the other parameters, since they're
the same as the *exception_raise*()?

https://codereview.chromium.org/567283002/diff/20001/util/mach/exc_client_var...
File util/mach/exc_client_variants_test.cc (right):

https://codereview.chromium.org/567283002/diff/20001/util/mach/exc_client_var...
util/mach/exc_client_variants_test.cc:143: mach_exception_data_type_t code[] = {
const?

https://codereview.chromium.org/567283002/diff/20001/util/mach/exc_client_var...
util/mach/exc_client_variants_test.cc:151: thread =
pthread_mach_thread_np(pthread_self());
Why do you do this instead of just mach_thread_self()?

[Mark Mentovai, 2014-09-15 21:53:02]

All feedback addressed. What do you think of this handling of MachThreadSelf()?
Would you prefer it in mach_extensions.{cc,h}? I could see putting it in there
too.

[Robert Sesek, 2014-09-15 23:17:55]

LGTM

On 2014/09/15 21:53:02, Mark Mentovai wrote:
> All feedback addressed. What do you think of this handling of
MachThreadSelf()?
> Would you prefer it in mach_extensions.{cc,h}? I could see putting it in there
> too.

I think mach_extensions makes sense, but I don't feel strongly either way.

[Mark Mentovai, 2014-09-16 13:47:45]

I’m going with mach_extensions.h.

[Mark Mentovai, 2014-09-16 13:48:07]

Committed patchset #4 (id:60001) manually as 1e7cdb3 (presubmit successful).