Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 567223002: Revert "Adding DumpAccessibilityTree Tests (8 of 20)" (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Adding DumpAccessibilityTree Tests (8 of 20)" This reverts commit 711d923e3b9dd778e482f991f280e6dd937d1abf. flaky a bunch of times. as an example, see http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/22538/steps/content_browsertests/logs/AccessibilityFrameset DumpAccessibilityTreeTest.AccessibilityFrameset (run #1): [ RUN ] DumpAccessibilityTreeTest.AccessibilityFrameset Testing: E:\b\build\slave\Win7_Tests__dbg__2_\build\src\content\test\data\accessibility\frameset.html c:\b\build\slave\win_builder__dbg_\build\src\content\browser\accessibility\dump_accessibility_tree_browsertest.cc(252): error: Value of: is_different Actual: true Expected: false [3080:2208:0913/171203:4867433:WARNING:channel.cc(211)] WriteMessage() while shutting down * Line Expected - ---- -------- 1 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE 2 ROLE_SYSTEM_CLIENT FOCUSABLE 3 IA2_ROLE_SCROLL_PANE 4 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE 5 IA2_ROLE_PARAGRAPH 6 ROLE_SYSTEM_STATICTEXT name='My favorite browser is ' 7 ROLE_SYSTEM_STATICTEXT name='ABC' 8 ROLE_SYSTEM_STATICTEXT name='Chrome' 9 ROLE_SYSTEM_STATICTEXT name='!' 10 ROLE_SYSTEM_CLIENT FOCUSABLE 11 IA2_ROLE_SCROLL_PANE 12 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE * 13 IA2_ROLE_PARAGRAPH 14 ROLE_SYSTEM_STATICTEXT name='This test is to check ' 15 ROLE_SYSTEM_STATICTEXT name='mark tag' 16 ROLE_SYSTEM_STATICTEXT name='.' 17 \u003C-- End-of-file --> Actual ------ ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ROLE_SYSTEM_CLIENT FOCUSABLE IA2_ROLE_SCROLL_PANE ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE IA2_ROLE_PARAGRAPH ROLE_SYSTEM_STATICTEXT name='My favorite browser is ' ROLE_SYSTEM_STATICTEXT name='ABC' ROLE_SYSTEM_STATICTEXT name='Chrome' ROLE_SYSTEM_STATICTEXT name='!' ROLE_SYSTEM_CLIENT FOCUSABLE IA2_ROLE_SCROLL_PANE ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE [ FAILED ] DumpAccessibilityTreeTest.AccessibilityFrameset, where TypeParam = and GetParam() = (1903 ms) BUG= Committed: https://chromium.googlesource.com/chromium/src/+/af71ddc669b073844cbc10d6e0f8fd9f3cf36e98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -418 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 9 chunks +0 lines, -40 lines 0 comments Download
D content/test/data/accessibility/aria-atomic.html View 1 chunk +0 lines, -12 lines 0 comments Download
D content/test/data/accessibility/aria-atomic-expected-android.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/aria-atomic-expected-mac.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/aria-atomic-expected-win.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/aria-row.html View 1 chunk +0 lines, -19 lines 0 comments Download
D content/test/data/accessibility/aria-row-expected-android.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D content/test/data/accessibility/aria-row-expected-mac.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D content/test/data/accessibility/aria-row-expected-win.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D content/test/data/accessibility/body.html View 1 chunk +0 lines, -6 lines 0 comments Download
D content/test/data/accessibility/body-expected-android.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/accessibility/body-expected-mac.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/body-expected-win.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/caption.html View 1 chunk +0 lines, -22 lines 0 comments Download
D content/test/data/accessibility/caption-expected-android.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D content/test/data/accessibility/caption-expected-mac.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D content/test/data/accessibility/caption-expected-win.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D content/test/data/accessibility/frameset.html View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/accessibility/frameset-expected-android.txt View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/accessibility/frameset-expected-mac.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D content/test/data/accessibility/frameset-expected-win.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D content/test/data/accessibility/i.html View 1 chunk +0 lines, -8 lines 0 comments Download
D content/test/data/accessibility/i-expected-android.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/accessibility/i-expected-mac.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/i-expected-win.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/ins.html View 1 chunk +0 lines, -8 lines 0 comments Download
D content/test/data/accessibility/ins-expected-android.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/ins-expected-mac.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D content/test/data/accessibility/ins-expected-win.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D content/test/data/accessibility/legend.html View 1 chunk +0 lines, -17 lines 0 comments Download
D content/test/data/accessibility/legend-expected-android.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D content/test/data/accessibility/legend-expected-mac.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/accessibility/legend-expected-win.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/accessibility/mark.html View 1 chunk +0 lines, -8 lines 0 comments Download
D content/test/data/accessibility/mark-expected-android.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/mark-expected-mac.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/mark-expected-win.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/object.html View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/accessibility/object-expected-android.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/object-expected-mac.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/object-expected-win.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/table-simple.html View 1 chunk +5 lines, -7 lines 0 comments Download
M content/test/data/accessibility/table-simple-expected-android.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M content/test/data/accessibility/table-simple-expected-mac.txt View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af71ddc669b073844cbc10d6e0f8fd9f3cf36e98 Cr-Commit-Position: refs/heads/master@{#294764}
6 years, 3 months ago (2014-09-14 06:11:24 UTC) #1
jam
6 years, 3 months ago (2014-09-14 06:11:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as af71ddc.

Powered by Google App Engine
This is Rietveld 408576698