Remove RGB32 from VideoFrame::Format.

Remove RGB32 from VideoFrame::Format.

It wasn't used anywhere outside of the unit tests.

BUG=313827
TBR=danakj

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233046

[rileya (GONE FROM CHROMIUM), 2013-11-04 19:25:53]

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
File media/base/video_frame_unittest.cc (right):

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
media/base/video_frame_unittest.cc:21: static inline size_t RoundUp(size_t
value, size_t alignment) {
This was copied from video_frame.cc... in the interest of preventing code
duplication, is this something that might be good to make into a helper
somewhere more accessible?

[scherkus (not reviewing), 2013-11-04 22:54:34]

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
File media/base/video_frame_unittest.cc (right):

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
media/base/video_frame_unittest.cc:21: static inline size_t RoundUp(size_t
value, size_t alignment) {
On 2013/11/04 19:25:53, rileya wrote:
> This was copied from video_frame.cc... in the interest of preventing code
> duplication, is this something that might be good to make into a helper
> somewhere more accessible?

either:
  1) dump this in media/base/video_util.h
  2) pick kWidth/Height constants so you don't need to use RoundUp() etc. here

(this is just testing yuv_convert.h so we can pick #s that satisfy its
requirements -- some of those RoundUp() computations in VideoFrame are to handle
video decoding where things need to be macroblocked aligned vs. YUV->RGB)

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
media/base/video_frame_unittest.cc:61: uint8* data =
reinterpret_cast<uint8*>(base::AlignedAlloc(
s/data/rgb_data/

[rileya (GONE FROM CHROMIUM), 2013-11-04 23:51:41]

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
File media/base/video_frame_unittest.cc (right):

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
media/base/video_frame_unittest.cc:21: static inline size_t RoundUp(size_t
value, size_t alignment) {
On 2013/11/04 22:54:34, scherkus wrote:
> On 2013/11/04 19:25:53, rileya wrote:
> > This was copied from video_frame.cc... in the interest of preventing code
> > duplication, is this something that might be good to make into a helper
> > somewhere more accessible?
> 
> either:
>   1) dump this in media/base/video_util.h
>   2) pick kWidth/Height constants so you don't need to use RoundUp() etc. here
> 
> (this is just testing yuv_convert.h so we can pick #s that satisfy its
> requirements -- some of those RoundUp() computations in VideoFrame are to
handle
> video decoding where things need to be macroblocked aligned vs. YUV->RGB)

Alright, I did 2).

https://codereview.chromium.org/56713002/diff/1/media/base/video_frame_unitte...
media/base/video_frame_unittest.cc:61: uint8* data =
reinterpret_cast<uint8*>(base::AlignedAlloc(
On 2013/11/04 22:54:34, scherkus wrote:
> s/data/rgb_data/

Done.

[scherkus (not reviewing), 2013-11-04 23:56:16]

lgtm

[commit-bot: I haz the power, 2013-11-05 00:45:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rileya@chromium.org/56713002/60001

[commit-bot: I haz the power, 2013-11-05 01:13:53]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 01:24:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rileya@chromium.org/56713002/60001

[commit-bot: I haz the power, 2013-11-05 03:20:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rileya@chromium.org/56713002/60001

[commit-bot: I haz the power, 2013-11-05 04:14:10]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-11-05 18:01:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rileya@chromium.org/56713002/60001

[commit-bot: I haz the power, 2013-11-05 19:10:54]

Change committed as 233046

[danakj1, 2013-11-11 23:40:50]

cc LGTM