Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 567083002: Issue 20358. Don't report referenced names of named parameters in named expressions as possible sha… (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 20358. Don't report referenced names of named parameters in named expressions as possible shadowing. R=paulberry@google.com BUG= https://code.google.com/p/dart/issues/detail?id=20358 Committed: https://code.google.com/p/dart/source/detail?r=40240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 4 chunks +10 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-12 22:14:12 UTC) #1
Paul Berry
lgtm
6 years, 3 months ago (2014-09-15 13:43:59 UTC) #2
scheglov
6 years, 3 months ago (2014-09-15 14:48:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698