Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 567073002: Make "rt" library Linux-only in GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make "rt" library Linux-only in GN build. This was added to fix the component build on Linux, but Android doesn't have this library. R=jamesr@chromium.org TBR=jamesr Committed: https://crrev.com/730675331a23c376eb8be35b399902f1cdec855f Cr-Commit-Position: refs/heads/master@{#294680}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M sandbox/linux/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 3 months ago (2014-09-12 21:47:40 UTC) #1
jamesr
lgtm
6 years, 3 months ago (2014-09-12 22:00:40 UTC) #2
brettw
Committed patchset #2 (id:20001) to pending queue manually as 0570832.
6 years, 3 months ago (2014-09-12 22:27:04 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:29:46 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/730675331a23c376eb8be35b399902f1cdec855f
Cr-Commit-Position: refs/heads/master@{#294680}

Powered by Google App Engine
This is Rietveld 408576698