Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 567063003: bindings: Fixes custom versions of associateWithWrapper. (Closed)

Created:
6 years, 3 months ago by Yuki
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

bindings: Fixes custom versions of associateWithWrapper. Fixes MessageEvent and ImageData's associateWithWrapper. My first code in http://crrev.com/542113003 assumed that associateWithWrapper was non-virtual method, but it was changed to be virtual. So I had to change the implementation when and how to call associateWithWrapper from wrap (my first code assumed that wrap calls the same class's associateWithWrapper because it was not virtual, but since associateWithWrapper was changed to be virtual during the code review, now wrap calls most derived class's associateWithWrapper). BUG=413041, 235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
M Source/core/events/MessageEvent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/events/MessageEvent.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/ImageData.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/ImageData.cpp View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL?
6 years, 3 months ago (2014-09-15 13:53:26 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-15 15:02:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567063003/1
6 years, 3 months ago (2014-09-15 15:10:16 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 15:16:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181983

Powered by Google App Engine
This is Rietveld 408576698