Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: Source/bindings/dart/scripts/dart_interface.py

Issue 566983005: Fix missing .get() to convert a RefPtr to a ptr for Uint8ClampedArray (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/dart/scripts/dart_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/scripts/dart_interface.py
diff --git a/Source/bindings/dart/scripts/dart_interface.py b/Source/bindings/dart/scripts/dart_interface.py
index 5a3c22fec6508db95e55a6d340da2bcd220bcfe0..c4da90873a697bc5a89c20a92f8ef0ddccbb1e18 100644
--- a/Source/bindings/dart/scripts/dart_interface.py
+++ b/Source/bindings/dart/scripts/dart_interface.py
@@ -948,7 +948,9 @@ def constructor_argument_list(interface, constructor):
def cpp_argument(argument):
argument_name = dart_types.check_reserved_name(argument.name)
idl_type = argument.idl_type
- if isinstance(idl_type, IdlArrayType):
+ # FIXMEDART: there has to be a cleaner way to check for arraylike
+ # types such as Uint8ClampedArray.
+ if isinstance(idl_type, IdlArrayType) or idl_type.preprocessed_type.is_typed_array_type:
return '%s.get()' % argument_name
return argument_name
« no previous file with comments | « no previous file | Source/bindings/dart/scripts/dart_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698