Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 566963002: Add gyp_vars to fake context in sdk build script. (Closed)

Created:
6 years, 3 months ago by bradn
Modified:
6 years, 3 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add gyp_vars to fake context in sdk build script. We reuse SetupWindowEnvironment from the nacl build, in the sdk build. To do this we inject a fake build context. Previously windows in particular just needed an empty mutable context. Now it assumes gyp_vars is set to a list of some kind. Initializing 'gyp_vars' to unblock a deps roll. BUG=None TEST=trybots R=binji@chromium.org Committed: https://crrev.com/5831c275cccc77e5eb9074377bc69c3d795f0778 Cr-Commit-Position: refs/heads/master@{#294634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M native_client_sdk/src/build_tools/buildbot_common.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
6 years, 3 months ago (2014-09-12 17:17:27 UTC) #1
binji
lgtm
6 years, 3 months ago (2014-09-12 17:18:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566963002/1
6 years, 3 months ago (2014-09-12 17:19:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 44ee6b5e172e1819cecb4043dd13e0f1b854cbd7
6 years, 3 months ago (2014-09-12 19:35:11 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:38:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5831c275cccc77e5eb9074377bc69c3d795f0778
Cr-Commit-Position: refs/heads/master@{#294634}

Powered by Google App Engine
This is Rietveld 408576698