Do not display lock for hosted domains

chrome/browser/profiles/gaia_info_update_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/gaia_info_update_service.h"
 
 #include "base/prefs/pref_service.h"
+#include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/common/pref_names.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "content/public/browser/notification_details.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/image/image.h"
 
 namespace {
 
@@ skipping 105 matching lines @@
   DCHECK_NE(profile_index, std::string::npos);
 
   if (picture_status == ProfileDownloader::PICTURE_SUCCESS) {
     profile_->GetPrefs()->SetString(prefs::kProfileGAIAInfoPictureURL,
                                     picture_url);
     gfx::Image gfx_image = gfx::Image::CreateFrom1xBitmap(bitmap);
     cache.SetGAIAPictureOfProfileAtIndex(profile_index, &gfx_image);
   } else if (picture_status == ProfileDownloader::PICTURE_DEFAULT) {
     cache.SetGAIAPictureOfProfileAtIndex(profile_index, NULL);
   }
+
+  base::string16 hosted_domain = downloader->GetProfileHostedDomain();
+  profile_->GetPrefs()->SetInteger(prefs::kProfileIsLockableVersion,

[noms (inactive), 2014/09/12 19:33:25]

You should add a comment that this only allows non hosted domains, i.e. google
or gmail

[Mike Lerman, 2014/09/15 14:08:55]

Added the comment by the definition of the version const in profile state.

[noms (inactive), 2014/09/15 18:52:40]

Hmm, but the comment would be useful here as well. Like, why allow only
"google.com" otherwise?

On 2014/09/15 14:08:55, Mike Lerman wrote:

[Mike Lerman, 2014/09/15 19:51:41]

Hmm I wrote some wording I hope is good.

+                                   profiles::kCurrentLockAlgorithmVersion);
+  if (hosted_domain.empty() || hosted_domain == base::UTF8ToUTF16("google.com"))
+    profile_->GetPrefs()->SetBoolean(prefs::kProfileIsLockable, true);
+  else
+    profile_->GetPrefs()->SetBoolean(prefs::kProfileIsLockable, false);

[noms (inactive), 2014/09/12 19:33:25]

This could be 
profile_->GetPrefs()->SetBoolean(prefs::kProfileIsLockable, 
    hosted_domain.empty() || hosted_domain == base::UTF8ToUTF16("google.com"));

[Mike Lerman, 2014/09/15 14:08:55]

Ugh ternaries, so unreadable! Done :P

 }
 
 void GAIAInfoUpdateService::OnProfileDownloadFailure(
     ProfileDownloader* downloader,
     ProfileDownloaderDelegate::FailureReason reason) {
   profile_image_downloader_.reset();
 
   // Save the last updated time.
   last_updated_ = base::Time::Now();
   profile_->GetPrefs()->SetInt64(prefs::kProfileGAIAInfoUpdateTime,
@@ skipping 59 matching lines @@
     const std::string& account_id,
     const std::string& username,
     const std::string& password) {
   OnUsernameChanged(username);
 }
 
 void GAIAInfoUpdateService::GoogleSignedOut(const std::string& account_id,
                                             const std::string& username) {
   OnUsernameChanged(std::string());
 }