Issue 566933003: Add mojo_view_manager -> skia dep

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 566933003: Add mojo_view_manager -> skia dep (Closed)

Created:
6 years, 3 months ago by jamesr

Modified:
6 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add mojo_view_manager -> skia dep Fixes windows component error since we use SkMatrix in DrawViewTree. BUG=413727 Committed: https://crrev.com/ba547288fe9ee552df607a98a1c7ae61d96cc8ff Cr-Commit-Position: refs/heads/master@{#294625}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	mojo/mojo_services.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

lgtm, thanks (I'll try to answer the "why not on other bots" question on the ...

6 years, 3 months ago (2014-09-12 16:48:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566933003/1

6 years, 3 months ago (2014-09-12 16:50:29 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as a8078c4e1abf33f8da6fecfbb1eb71dc45cfe3be

6 years, 3 months ago (2014-09-12 19:12:50 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-12 19:18:28 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ba547288fe9ee552df607a98a1c7ae61d96cc8ff
Cr-Commit-Position: refs/heads/master@{#294625}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages