Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 566893002: Add a fallback for unparseable Java version numbers on Mac. (Closed)

Created:
6 years, 3 months ago by Bernhard Bauer
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, arv+watch_chromium.org, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Add a fallback for unparseable Java version numbers on Mac. BUG=410651 Committed: https://crrev.com/71cdc551e2b707119a82bd7cb064e555248e24df Cr-Commit-Position: refs/heads/master@{#294672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/resources/plugin_metadata/plugins_mac.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Bernhard Bauer
Please review.
6 years, 3 months ago (2014-09-12 12:36:27 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-12 19:10:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566893002/1
6 years, 3 months ago (2014-09-12 19:38:42 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-12 21:43:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566893002/1
6 years, 3 months ago (2014-09-12 21:53:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3699f89b078d7943b5a4247445739027e3f6d3e4
6 years, 3 months ago (2014-09-12 22:01:06 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:03:17 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/71cdc551e2b707119a82bd7cb064e555248e24df
Cr-Commit-Position: refs/heads/master@{#294672}

Powered by Google App Engine
This is Rietveld 408576698