Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: chrome/browser/resources/options/website_settings.js

Issue 566863005: Expose the Website Settings page in the Content Setting page if it is enabled via flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/website_settings.js
diff --git a/chrome/browser/resources/options/website_settings.js b/chrome/browser/resources/options/website_settings.js
index 4c909ac40cda7810fd42ee325e30ab3f4f21bbc9..be64be6be36da321610b7e84753655b3dae35c7a 100644
--- a/chrome/browser/resources/options/website_settings.js
+++ b/chrome/browser/resources/options/website_settings.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-cr.define('options', function() {
+cr.define('options.ContentSettings', function() {
/** @const */ var Page = cr.ui.pageManager.Page;
/** @const */ var PageManager = cr.ui.pageManager.PageManager;
/** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
@@ -59,12 +59,6 @@ cr.define('options', function() {
$('website-settings-overlay-confirm').onclick =
PageManager.closeOverlay.bind(PageManager);
- $('resourceType').onchange = function(event) {
- var target = event.target;
- assert(target.tagName == 'SELECT');
- WebsiteSettingsManager.getInstance().updatePage_(target.value);
- };
-
$('global-setting').onchange = function(event) {
chrome.send('setDefaultContentSetting', [this.value]);
};
@@ -93,8 +87,6 @@ cr.define('options', function() {
else
hash = 'geolocation';
this.updatePage_(hash);
-
- $('resourceType').value = hash;
},
/**
@@ -238,6 +230,9 @@ cr.define('options', function() {
$('website-settings-global-controls').hidden = false;
chrome.send('updateDefaultSetting');
}
+
+ $('website-settings-title').textContent =
+ loadTimeData.getString(permissionString + 'TabLabel');
}
};

Powered by Google App Engine
This is Rietveld 408576698