Enabling webview in app_shell.

Enabling webview in app_shell.

This CL registers the webview tag in extensions, allowing it to be used inside app_shell. The webview browser sample should be working with this patch.

For now, not all the webview APIs are supported, the APIs that are not supported are: contextMenus, webrequest, declarativeWebRequest and permissions (videoCapture, pointerLock, geolocation).

BUG=352293
Committed: https://crrev.com/0330a7e9fc13f03380f86916b0b2cf718f36b1f8
Cr-Commit-Position: refs/heads/master@{#294689}

[lfg, 2014-09-12 16:32:42]

lfg@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2014-09-12 17:03:58]

lgtm with nits.

https://chromiumcodereview.appspot.com/566863004/diff/20001/chrome/renderer/r...
File chrome/renderer/resources/extensions/chrome_web_view.js (right):

https://chromiumcodereview.appspot.com/566863004/diff/20001/chrome/renderer/r...
chrome/renderer/resources/extensions/chrome_web_view.js:7: var
DeclarativeWebRequestSchema =
Sort these.

https://chromiumcodereview.appspot.com/566863004/diff/20001/chrome/renderer/r...
chrome/renderer/resources/extensions/chrome_web_view.js:17: 
nit: remove empty line.

https://chromiumcodereview.appspot.com/566863004/diff/20001/chrome/renderer/r...
chrome/renderer/resources/extensions/chrome_web_view.js:53: function
DeclarativeWebRequestEvent(opt_eventName,
nit: move this and line 68 around to top block of this file, e.g. after
CHROME_WEB_VIEW_EVENTS.

[lazyboy, 2014-09-12 17:17:26]

https://codereview.chromium.org/566863004/diff/20001/chrome/renderer/resource...
File chrome/renderer/resources/extensions/chrome_web_view.js (right):

https://codereview.chromium.org/566863004/diff/20001/chrome/renderer/resource...
chrome/renderer/resources/extensions/chrome_web_view.js:17: 
On 2014/09/12 17:03:57, lazyboy wrote:
> nit: remove empty line.

Wrong comment.

[lfg, 2014-09-12 17:18:57]

https://codereview.chromium.org/566863004/diff/20001/chrome/renderer/resource...
File chrome/renderer/resources/extensions/chrome_web_view.js (right):

https://codereview.chromium.org/566863004/diff/20001/chrome/renderer/resource...
chrome/renderer/resources/extensions/chrome_web_view.js:7: var
DeclarativeWebRequestSchema =
On 2014/09/12 17:03:57, lazyboy wrote:
> Sort these.

Done.

https://codereview.chromium.org/566863004/diff/20001/chrome/renderer/resource...
chrome/renderer/resources/extensions/chrome_web_view.js:53: function
DeclarativeWebRequestEvent(opt_eventName,
On 2014/09/12 17:03:57, lazyboy wrote:
> nit: move this and line 68 around to top block of this file, e.g. after
> CHROME_WEB_VIEW_EVENTS.

Done.

[lfg, 2014-09-12 17:39:41]

lfg@chromium.org changed reviewers:
+ jamescook@chromium.org, rockot@chromium.org, sky@chromium.org

[lfg, 2014-09-12 17:39:41]

jamescook@chromium.org: Please review changes in 

*.gyp, *.gn, shell_browser_context.*

sky@chromium.org: Please review changes in 

*.gyp, *.gn

rockot@chromium.org: Please review changes in 

everything :)

[sky, 2014-09-12 19:55:45]

On 2014/09/12 17:39:41, lfg wrote:
> mailto:jamescook@chromium.org: Please review changes in 
> 
> *.gyp, *.gn, shell_browser_context.*
> 
> mailto:sky@chromium.org: Please review changes in 
> 
> *.gyp, *.gn

The only one I'm an owner of here is athena. Oshima is better for that.
sky->oshima
> 
> mailto:rockot@chromium.org: Please review changes in 
> 
> everything :)

[sky, 2014-09-12 19:55:57]

sky@chromium.org changed reviewers:
+ oshima@chromium.org
- sky@chromium.org

[sky, 2014-09-12 19:56:10]

+oshima for *.gyp *.gn

[James Cook, 2014-09-12 20:11:07]

Looking good, one question.

Also, please write a more detailed commit description.

https://codereview.chromium.org/566863004/diff/60001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/566863004/diff/60001/extensions/extensions.gy...
extensions/extensions.gyp:995:
'<(SHARED_INTERMEDIATE_DIR)/content/app/strings/content_strings_en-US.pak',
I don't see any new references to string resources in the rest of this CL.  What
string does it need to access?  Was this missed in a previous CL?

[lfg, 2014-09-12 20:16:25]

https://codereview.chromium.org/566863004/diff/60001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/566863004/diff/60001/extensions/extensions.gy...
extensions/extensions.gyp:995:
'<(SHARED_INTERMEDIATE_DIR)/content/app/strings/content_strings_en-US.pak',
On 2014/09/12 20:11:07, James Cook wrote:
> I don't see any new references to string resources in the rest of this CL. 
What
> string does it need to access?  Was this missed in a previous CL?

The string that was missing was IDS_FORM_SUBMIT_LABEL (possibly others from the
same file, but this was the first one I was crashing).

[James Cook, 2014-09-12 20:20:30]

LGTM!

Nice work on getting all this stuff factored out.

[oshima, 2014-09-12 20:25:08]

athena/ lgtm

[Ken Rockot(use gerrit already), 2014-09-12 21:27:38]

LGTM!

[lfg, 2014-09-12 22:05:32]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-12 22:09:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566863004/60001

[commit-bot: I haz the power, 2014-09-12 22:59:26]

Committed patchset #4 (id:60001) as 478f71ef3fa5573f2689164542e314124d897c4b

[commit-bot: I haz the power, 2014-09-12 23:09:44]

Patchset 4 (id:??) landed as
https://crrev.com/0330a7e9fc13f03380f86916b0b2cf718f36b1f8
Cr-Commit-Position: refs/heads/master@{#294689}