Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 566863003: Declaring the weak_ptr_factory in proper order. (Closed)

Created:
6 years, 3 months ago by Anand Ratn (left samsung)
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order. Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/chromeos" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/04aae9efd866a7fb001f172a3a18b867e0b22543 Cr-Commit-Position: refs/heads/master@{#295005}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
Anand Ratn (left samsung)
davemoore@chromium.org : Please review changes in src/chrome/browser/chromeos module.
6 years, 3 months ago (2014-09-12 14:34:33 UTC) #2
Anand Ratn (left samsung)
oshima@chromium.org : Please review changes in src/chrome/browser/chromeos module.
6 years, 3 months ago (2014-09-15 07:06:08 UTC) #4
oshima
lgtm
6 years, 3 months ago (2014-09-15 16:06:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566863003/1
6 years, 3 months ago (2014-09-16 03:27:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b51a09e635e2650417c1a98b69ab652e3a90210b
6 years, 3 months ago (2014-09-16 04:18:20 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 04:20:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04aae9efd866a7fb001f172a3a18b867e0b22543
Cr-Commit-Position: refs/heads/master@{#295005}

Powered by Google App Engine
This is Rietveld 408576698