Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 566853006: Replace the only use of media::MockStatisticsCB with a bound method. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace the only use of media::MockStatisticsCB with a bound method. No need to keep useless helper mocks around. This also helps clean up VideoRendererImpl's unit tests in preparation for switching to the scheduler. Committed: https://crrev.com/c13ad6e22d9f25956827e5d61f0fd55a9e403359 Cr-Commit-Position: refs/heads/master@{#294704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M media/base/mock_filters.h View 1 chunk +0 lines, -9 lines 0 comments Download
M media/base/mock_filters.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/filters/video_renderer_impl_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scherkus (not reviewing)
6 years, 3 months ago (2014-09-12 21:19:48 UTC) #2
DaleCurtis
lgtm
6 years, 3 months ago (2014-09-12 21:25:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566853006/1
6 years, 3 months ago (2014-09-12 21:31:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2552a41e77c24148ca84be33754b504a38593529
6 years, 3 months ago (2014-09-13 00:42:31 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 00:47:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c13ad6e22d9f25956827e5d61f0fd55a9e403359
Cr-Commit-Position: refs/heads/master@{#294704}

Powered by Google App Engine
This is Rietveld 408576698