Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 566843004: X87: Added CallInterfaceDescriptors to all code stubs. (Closed)

Created:
6 years, 3 months ago by Jing
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Added CallInterfaceDescriptors to all code stubs. port r23854. original commit message: Added CallInterfaceDescriptors to all code stubs. A handful of code stubs are too complex to be described this way, and they are encoded with the macro DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR(). Along the way: * allowed inheritance of CallInterfaceDescriptors. * Defined static Register methods for some of the new CallInterfaceDescriptors. We could go a lot further here, but it doesn't have to be done immediately. * Added Representation arrays to some CallInterfaceDescriptors, especially where future hydrogen versions of the stubs could benefit from this knowledge. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 3 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jing
6 years, 3 months ago (2014-09-12 07:31:34 UTC) #2
Weiliang
lgtm
6 years, 3 months ago (2014-09-12 07:51:11 UTC) #3
Weiliang
6 years, 3 months ago (2014-09-12 07:54:58 UTC) #4
Committed as 23898

Powered by Google App Engine
This is Rietveld 408576698