Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 566833002: Update WebTask in chromium c++ style (Closed)

Created:
6 years, 3 months ago by Abhishek
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update WebTask in chromium c++ style BUG=331299 Committed: https://crrev.com/ab71acb31e8a2241fe7ec07d460a425700574081 Cr-Commit-Position: refs/heads/master@{#294603}

Patch Set 1 #

Total comments: 4

Patch Set 2 : resolved nits #

Patch Set 3 : resolved build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -197 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/WebTask.h View 1 chunk +0 lines, -77 lines 0 comments Download
D content/shell/renderer/test_runner/WebTask.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_user_media_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_user_media_client.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/spell_check_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/spell_check_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 5 chunks +7 lines, -9 lines 0 comments Download
A content/shell/renderer/test_runner/web_task.h View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/web_task.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Abhishek
PTAL !
6 years, 3 months ago (2014-09-12 06:33:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nits https://codereview.chromium.org/566833002/diff/1/content/shell/renderer/test_runner/web_task.cc File content/shell/renderer/test_runner/web_task.cc (right): https://codereview.chromium.org/566833002/diff/1/content/shell/renderer/test_runner/web_task.cc#newcode8 content/shell/renderer/test_runner/web_task.cc:8: #include "third_party/WebKit/public/web/WebKit.h" nit. empty line between ...
6 years, 3 months ago (2014-09-12 07:47:03 UTC) #3
Abhishek
All comments are incorporated. PTAL! https://codereview.chromium.org/566833002/diff/1/content/shell/renderer/test_runner/web_task.cc File content/shell/renderer/test_runner/web_task.cc (right): https://codereview.chromium.org/566833002/diff/1/content/shell/renderer/test_runner/web_task.cc#newcode8 content/shell/renderer/test_runner/web_task.cc:8: #include "third_party/WebKit/public/web/WebKit.h" On 2014/09/12 ...
6 years, 3 months ago (2014-09-12 08:00:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566833002/20001
6 years, 3 months ago (2014-09-12 08:53:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/55155) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/14909)
6 years, 3 months ago (2014-09-12 09:05:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566833002/40001
6 years, 3 months ago (2014-09-12 15:45:50 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 256dbf7a7dc5f0aeeacc5581d56a231df756f80c
6 years, 3 months ago (2014-09-12 16:48:51 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 16:54:39 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ab71acb31e8a2241fe7ec07d460a425700574081
Cr-Commit-Position: refs/heads/master@{#294603}

Powered by Google App Engine
This is Rietveld 408576698