chrome/browser/chromeos/input_method/input_method_util.cc - Issue 566823003: Move declarative_webrequest: action, rules_registry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.cc

Issue 566823003: Move declarative_webrequest: action, rules_registry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert extension_constants changes (this patch violates DEPS ..) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/input_method/input_method_util.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_util.cc b/chrome/browser/chromeos/input_method/input_method_util.cc

index f91cb1a42984a6a01128d3f533c785794dc9aa4e..b236f17a4465d592f5a4ee9164406fddf6ef6f02 100644

--- a/chrome/browser/chromeos/input_method/input_method_util.cc

+++ b/chrome/browser/chromeos/input_method/input_method_util.cc

@@ -15,12 +15,12 @@

#include "base/strings/string_split.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/common/extensions/extension_constants.h"

// TODO(nona): move this header from this file.

#include "chrome/grit/generated_resources.h"

#include "chromeos/ime/component_extension_ime_manager.h"

#include "chromeos/ime/extension_ime_util.h"

// For SetHardwareKeyboardLayoutForTesting.

+#include "chrome/common/extensions/extension_constants.h"

Daniel Erat 2014/09/16 17:42:10 i don't understand why this header got moved down

wjmaclean 2014/09/16 17:51:59 Sorry, this got out of order when I moved extensio

#include "chromeos/ime/fake_input_method_delegate.h"

#include "chromeos/ime/input_method_delegate.h"

#include "chromeos/ime/input_method_whitelist.h"

« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative/declarative_apitest.cc » ('j') | no next file with comments »