Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 566783002: Mojo: Remove DCHECK disallowing passing of a remote message pipe. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove DCHECK disallowing passing of a remote message pipe. This will make it set up a proxy message pipe, and is a stopgap measure until we have proper message pipe passing (across multiple channels/processes). I don't know what bugs there might be, though I added a basic test (across a single remote message pipe and back). I should add yet more tests. R=davemoore@chromium.org Committed: https://crrev.com/fe9922293ff4500b2701880877b33ee70d90b0ea Cr-Commit-Position: refs/heads/master@{#294686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -6 lines) Patch
M mojo/system/message_pipe.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 1 chunk +225 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 3 months ago (2014-09-11 23:10:01 UTC) #1
DaveMoore
lgtm
6 years, 3 months ago (2014-09-12 22:01:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566783002/1
6 years, 3 months ago (2014-09-12 22:09:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1f2246c3a5acbc7d035401f327e44d1bf8faaa95
6 years, 3 months ago (2014-09-12 22:53:51 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:58:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe9922293ff4500b2701880877b33ee70d90b0ea
Cr-Commit-Position: refs/heads/master@{#294686}

Powered by Google App Engine
This is Rietveld 408576698