Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 566773005: PDF: Manipulate the selected text buffer to deal with special 0xfffe hyphens. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
gene
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PDF: Manipulate the selected text buffer to deal with special 0xfffe hyphens. Also format text to match Adobe Reader. BUG=307523 TEST=Manual, see bug (and duplicates for more examples) Committed: https://crrev.com/974086e8a7ca04b9bb947380bb2ac684c028edc1 Cr-Commit-Position: refs/heads/master@{#294638}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -36 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 3 chunks +69 lines, -36 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
https://codereview.chromium.org/566773005/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (left): https://codereview.chromium.org/566773005/diff/1/pdf/pdfium/pdfium_engine.cc#oldcode473 pdf/pdfium/pdfium_engine.cc:473: void TransformPageObjects(FPDF_PAGE page, const ClipBox& source_clip_box, This has been ...
6 years, 3 months ago (2014-09-11 23:13:10 UTC) #2
gene
lgtm
6 years, 3 months ago (2014-09-12 17:43:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566773005/1
6 years, 3 months ago (2014-09-12 18:30:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f837872f2b0afd9d176e7bf119d9dd5a46e192e7
6 years, 3 months ago (2014-09-12 19:46:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:50:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/974086e8a7ca04b9bb947380bb2ac684c028edc1
Cr-Commit-Position: refs/heads/master@{#294638}

Powered by Google App Engine
This is Rietveld 408576698