[telemetry] Split blink_perf up on Android.

tools/perf/benchmarks/blink_perf.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 from telemetry import benchmark
 from telemetry.core import util
 from telemetry.page import page_set
 from telemetry.page import page_test
@@ skipping 22 matching lines @@
       if candidate_path.startswith(tuple([os.path.join(path, s)
                                           for s in skipped])):
         continue
       if os.path.isdir(candidate_path):
         _AddDir(candidate_path, skipped)
       else:
         _AddPage(candidate_path)
 
   if os.path.isdir(path):
     skipped = []
     skipped_file = os.path.join(path, 'Skipped')

[tonyg, 2014/09/12 01:09:09]

Does this still work?

[tonyg, 2014/09/12 14:12:50]

Ping on this. If the skipped file is still respected then this lgtm.

[dtu, 2014/09/15 21:01:13]

You're right, this logic is flawed. Done.

     if os.path.exists(skipped_file):
       for line in open(skipped_file, 'r').readlines():
         line = line.strip()
         if line and not line.startswith('#'):
           skipped.append(line.replace('/', os.sep))
     _AddDir(path, skipped)
   else:
     _AddPage(path)
   ps = page_set.PageSet(file_path=os.getcwd()+os.sep, serving_dirs=serving_dirs)
   for url in page_urls:
@@ skipping 32 matching lines @@
       units = parts[-1]
       metric = page.display_name.split('.')[0].replace('/', '_')
       results.AddValue(list_of_scalar_values.ListOfScalarValues(
           results.current_page, metric, units, values))
 
       break
 
     print log
 
 
+@benchmark.Disabled('android')

[tonyg, 2014/09/12 01:09:09]

Please add a TODO indicating that once the desktop bots are running on recipes
we should remove this benchmark and enable the below on all platforms.

[dtu, 2014/09/12 03:18:52]

Done.

 class BlinkPerfAll(benchmark.Benchmark):
   tag = 'all'
   test = _BlinkPerfMeasurement
 
   def CreatePageSet(self, options):
     path = os.path.join(util.GetChromiumSrcDir(),
         'third_party', 'WebKit', 'PerformanceTests')
     return _CreatePageSetFromPath(path)
 
 
-@benchmark.Disabled
+@benchmark.Enabled('android')
 class BlinkPerfAnimation(benchmark.Benchmark):
   tag = 'animation'
   test = _BlinkPerfMeasurement
 
   def CreatePageSet(self, options):
     path = os.path.join(util.GetChromiumSrcDir(),
         'third_party', 'WebKit', 'PerformanceTests', 'Animation')
     return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfBindings(benchmark.Benchmark):
+  tag = 'bindings'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'Bindings')

[tonyg, 2014/09/12 01:09:09]

I'm on the fence about whether these dir names should be dynamic or static. Just
curious what the pros/cons are.

[dtu, 2014/09/12 03:18:52]

Pros:
- Much shorter code. Easy to glance at list of tests.
- Adding or removing dirs will automatically add or remove tests.

Cons:
- More complex code, possibly involving inspect.
- Hard to @Disable individual dirs.
- I excluded some folders that will always be skipped. (Dromaeo, Replay,
SunSpider, XSSAuditor, inspector) We'd need a blacklist here to avoid extra test
steps on the waterfall.

[tonyg, 2014/09/12 14:12:50]

Makes sense. I agree with your approach.

+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfCSS(benchmark.Benchmark):
+  tag = 'css'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'CSS')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfCanvas(benchmark.Benchmark):
+  tag = 'canvas'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'Canvas')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfDOM(benchmark.Benchmark):
+  tag = 'dom'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'DOM')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfEvents(benchmark.Benchmark):
+  tag = 'events'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'Events')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfInteractive(benchmark.Benchmark):
+  tag = 'interactive'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'Interactive')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfLayout(benchmark.Benchmark):
+  tag = 'layout'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'Layout')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfMutation(benchmark.Benchmark):
+  tag = 'mutation'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'Mutation')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfParser(benchmark.Benchmark):
+  tag = 'parser'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'Parser')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfSVG(benchmark.Benchmark):
+  tag = 'svg'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'SVG')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfShadowDOM(benchmark.Benchmark):
+  tag = 'shadow_dom'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'ShadowDOM')
+    return _CreatePageSetFromPath(path)
+
+
+@benchmark.Enabled('android')
+class BlinkPerfXMLHttpRequest(benchmark.Benchmark):
+  tag = 'xml_http_request'
+  test = _BlinkPerfMeasurement
+
+  def CreatePageSet(self, options):
+    path = os.path.join(util.GetChromiumSrcDir(),
+        'third_party', 'WebKit', 'PerformanceTests', 'XMLHttpRequest')
+    return _CreatePageSetFromPath(path)