Use a std::string to store return value from FieldTrialList::FindFullName()

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 1366 matching lines @@
 
   if (parsed_command_line().HasSwitch(switches::kEnableSdchOverHttps)) {
     net::SdchManager::EnableSecureSchemeSupport(true);
   } else {
     // Check SDCH field trial.
     const char kSdchFieldTrialName[] = "SDCH";
     const char kEnabledAllGroupName[] = "EnabledAll";
     const char kEnabledHttpOnlyGroupName[] = "EnabledHttpOnly";
     const char kDisabledAllGroupName[] = "DisabledAll";
 
-    base::StringPiece sdch_trial_group =
+    std::string sdch_trial_group_string =

[sky, 2014/09/12 18:14:49]

How about a comment so this doesn't happen again.

[Randy Smith (Not in Mondays), 2014/09/12 19:35:55]

Done.

         base::FieldTrialList::FindFullName(kSdchFieldTrialName);
+    base::StringPiece sdch_trial_group(sdch_trial_group_string);
     if (sdch_trial_group.starts_with(kEnabledAllGroupName)) {
       net::SdchManager::EnableSecureSchemeSupport(true);
       net::SdchManager::EnableSdchSupport(true);
     } else if (sdch_trial_group.starts_with(kEnabledHttpOnlyGroupName)) {
       net::SdchManager::EnableSdchSupport(true);
     } else if (sdch_trial_group.starts_with(kDisabledAllGroupName)) {
       net::SdchManager::EnableSdchSupport(false);
     }
   }
 
@@ skipping 279 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif
 #endif
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }