Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: athena/home/home_card_impl.cc

Issue 566753003: Hide the virtual keyboard when entering to overview mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: home card Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | athena/home/home_card_unittest.cc » ('j') | athena/home/home_card_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/home/home_card_impl.cc
diff --git a/athena/home/home_card_impl.cc b/athena/home/home_card_impl.cc
index cb38f3c01ab2ac6ae1c384ddaae307fc0769bbb9..c57c6284b44ab2029d2277e64d09c40c4bbf09b0 100644
--- a/athena/home/home_card_impl.cc
+++ b/athena/home/home_card_impl.cc
@@ -324,10 +324,10 @@ void HomeCardImpl::SetState(HomeCard::State state) {
if (state_ == HIDDEN) {
home_card_widget_->Hide();
} else {
- if (state_ == VISIBLE_CENTERED)
- home_card_widget_->Show();
- else
+ if (state_ == VISIBLE_MINIMIZED)
home_card_widget_->ShowInactive();
+ else
+ home_card_widget_->Show();
home_card_view_->SetStateWithAnimation(state);
layout_manager_->Layout(true);
}
@@ -407,7 +407,7 @@ void HomeCardImpl::OnGestureProgressed(
}
void HomeCardImpl::OnOverviewModeEnter() {
- if (state_ == VISIBLE_MINIMIZED)
+ if (state_ == HIDDEN || state_ == VISIBLE_MINIMIZED)
SetState(VISIBLE_BOTTOM);
}
« no previous file with comments | « no previous file | athena/home/home_card_unittest.cc » ('j') | athena/home/home_card_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698