Hide the virtual keyboard when entering to overview mode.

Hide the virtual keyboard when entering to overview mode.

BUG=413353
R=pkotwicz@chromium.org
TEST=athena_unittests

Committed: https://crrev.com/bf547ab81b930d0a45af6a56925d463e55633be0
Cr-Commit-Position: refs/heads/master@{#295500}

[pkotwicz, 2014-09-11 22:31:35]

This works LGTM

This is what I was thinking:
1) calling SetState(VISIBLE_BOTTOM) in HomeCardImpl::OnOverviewModeEnter() when
the state is HIDDEN
2) for HomeCardImpl::SetState() to activate the home card when it has the
VISIBLE_BOTTOM state. (I want to make that change as part of
https://codereview.chromium.org/546123002/)

[Jun Mukai, 2014-09-11 23:18:52]

On 2014/09/11 22:31:35, pkotwicz wrote:
> This works LGTM
> 
> This is what I was thinking:
> 1) calling SetState(VISIBLE_BOTTOM) in HomeCardImpl::OnOverviewModeEnter()
when
> the state is HIDDEN
> 2) for HomeCardImpl::SetState() to activate the home card when it has the
> VISIBLE_BOTTOM state. (I want to make that change as part of
> https://codereview.chromium.org/546123002/)

Ah, that approach sounds better and testable.  Uploaded the new patchset. PTAL.

[pkotwicz, 2014-09-11 23:40:11]

LGTM if the unit tests all pass (You may have to wait for
https://codereview.chromium.org/546123002/ to land for the unit tests to pass
with this change)

[pkotwicz, 2014-09-11 23:43:16]

https://codereview.chromium.org/566753003/diff/40001/athena/home/home_card_un...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/566753003/diff/40001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:95: // Toogle overview revives the home card
to bottom. Also home card gets
How about: "Toggling overview revives the bottom home card. Home card also gets
activated which will close the virtual keyboard."

[Jun Mukai, 2014-09-11 23:55:02]

Ah, I only run tests for HomeCard*.*.  Indeed
WindowManagerTest.OverviewModeBasics fails with this CL, I'll wait for your CL.

https://codereview.chromium.org/566753003/diff/40001/athena/home/home_card_un...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/566753003/diff/40001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:95: // Toogle overview revives the home card
to bottom. Also home card gets
On 2014/09/11 23:43:16, pkotwicz wrote:
> How about: "Toggling overview revives the bottom home card. Home card also
gets
> activated which will close the virtual keyboard."

Done.

[pkotwicz, 2014-09-18 13:18:30]

You should be able to land this CL now (after rebasing)
https://codereview.chromium.org/546123002/ has landed

[Jun Mukai, 2014-09-18 17:14:49]

The CQ bit was checked by mukai@chromium.org

[Jun Mukai, 2014-09-18 17:15:18]

On 2014/09/18 13:18:30, pkotwicz wrote:
> You should be able to land this CL now (after rebasing)
> https://codereview.chromium.org/546123002/ has landed

thanks for the reminder.  Confirmed the athena_unittests works well with this
CL.

[commit-bot: I haz the power, 2014-09-18 17:16:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566753003/60001

[commit-bot: I haz the power, 2014-09-18 17:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:19:36]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57744)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Jun Mukai, 2014-09-18 17:23:39]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:24:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566753003/80001

[commit-bot: I haz the power, 2014-09-18 18:21:19]

Committed patchset #5 (id:80001) as e855d77c423eb6c9ed3170a58b4acd4c9f29ba85

[commit-bot: I haz the power, 2014-09-18 18:22:01]

Patchset 5 (id:??) landed as
https://crrev.com/bf547ab81b930d0a45af6a56925d463e55633be0
Cr-Commit-Position: refs/heads/master@{#295500}