Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: tests/lib/mirrors/generic_type_mirror_test.dart

Issue 56673002: Mirror removals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: also update things in /pkg Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/mirrors/generic_type_mirror_test.dart
diff --git a/tests/lib/mirrors/generic_type_mirror_test.dart b/tests/lib/mirrors/generic_type_mirror_test.dart
index 6b38328f328bc5e78ed1b09a68a13a2057dc6d57..b2e8891997afcc12fa70738485fbe98aa2879329 100644
--- a/tests/lib/mirrors/generic_type_mirror_test.dart
+++ b/tests/lib/mirrors/generic_type_mirror_test.dart
@@ -23,13 +23,13 @@ void testInstance() {
ClassMirror bar = reflect(new Bar()).type;
ClassMirror baz = reflect(new Baz()).type;
ClassMirror hOfBaz = reflect(new H<Baz>()).type;
- VariableMirror field = foo.variables.values.single;
- MethodMirror getter = foo.getters.values.single;
- MethodMirror setter = foo.setters.values.single;
- MethodMirror m = foo.methods[const Symbol('m')];
- MethodMirror n = foo.methods[const Symbol('n')];
- MethodMirror o = foo.methods[const Symbol('o')];
- MethodMirror p = foo.methods[const Symbol('p')];
+ VariableMirror field = foo.declarations[#field];
+ MethodMirror getter = foo.declarations[#bar];
+ MethodMirror setter = foo.declarations[const Symbol('bar=')];
+ MethodMirror m = foo.declarations[const Symbol('m')];
+ MethodMirror n = foo.declarations[const Symbol('n')];
+ MethodMirror o = foo.declarations[const Symbol('o')];
+ MethodMirror p = foo.declarations[const Symbol('p')];
gbracha 2013/11/04 23:41:38 Why not #m, #n etc. ?
rmacnak 2013/11/06 01:28:35 Done.
Expect.equals(foo, field.owner);
Expect.equals(foo, getter.owner);
@@ -55,13 +55,13 @@ void testInstance() {
void testOriginalDeclaration() {
ClassMirror foo = reflectClass(Foo);
- VariableMirror field = foo.variables.values.single;
- MethodMirror getter = foo.getters.values.single;
- MethodMirror setter = foo.setters.values.single;
- MethodMirror m = foo.methods[const Symbol('m')];
- MethodMirror n = foo.methods[const Symbol('n')];
- MethodMirror o = foo.methods[const Symbol('o')];
- MethodMirror p = foo.methods[const Symbol('p')];
+ VariableMirror field = foo.declarations[#field];
+ MethodMirror getter = foo.declarations[#bar];
+ MethodMirror setter = foo.declarations[const Symbol('bar=')];
+ MethodMirror m = foo.declarations[const Symbol('m')];
+ MethodMirror n = foo.declarations[const Symbol('n')];
+ MethodMirror o = foo.declarations[const Symbol('o')];
+ MethodMirror p = foo.declarations[const Symbol('p')];
gbracha 2013/11/04 23:41:38 as above
TypeVariableMirror w = foo.typeVariables[0];
TypeVariableMirror v = foo.typeVariables[1];

Powered by Google App Engine
This is Rietveld 408576698