Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 566713004: [NaCl SDK] Reduce spew from build_updater.py (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M native_client_sdk/src/build_tools/build_updater.py View 2 chunks +3 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
binji
6 years, 3 months ago (2014-09-11 19:10:00 UTC) #1
Sam Clegg
https://codereview.chromium.org/566713004/diff/1/native_client_sdk/src/build_tools/build_updater.py File native_client_sdk/src/build_tools/build_updater.py (left): https://codereview.chromium.org/566713004/diff/1/native_client_sdk/src/build_tools/build_updater.py#oldcode145 native_client_sdk/src/build_tools/build_updater.py:145: buildbot_common.BuildStep('Create Updater') We don't want a build step for ...
6 years, 3 months ago (2014-09-11 19:13:11 UTC) #2
binji
https://codereview.chromium.org/566713004/diff/1/native_client_sdk/src/build_tools/build_updater.py File native_client_sdk/src/build_tools/build_updater.py (left): https://codereview.chromium.org/566713004/diff/1/native_client_sdk/src/build_tools/build_updater.py#oldcode145 native_client_sdk/src/build_tools/build_updater.py:145: buildbot_common.BuildStep('Create Updater') On 2014/09/11 19:13:11, Sam Clegg wrote: > ...
6 years, 3 months ago (2014-09-11 19:17:14 UTC) #3
Sam Clegg
lgtm
6 years, 3 months ago (2014-09-11 19:27:56 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c98044b806c3003c69d3d6b96286c670fe877648 Cr-Commit-Position: refs/heads/master@{#294490}
6 years, 3 months ago (2014-09-11 23:33:41 UTC) #5
binji
6 years, 3 months ago (2014-09-11 23:34:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as c98044b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698