Issue 566693003: ExcCrashRecoverOriginalException()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 566693003: ExcCrashRecoverOriginalException() (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Refactor EXC_CRASH code[0] processing into a new function, ExcCrashRecoverOriginalException(), and use it where sensible. TEST=util_test ExcVariantsTest.ExcCrashRecoverOriginalException … R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b4fe6dfae04961633e2ffd16fafcdddd8df3ee32

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -31 lines)			Patch
M	tools/catch_exception_tool.cc	View	1 chunk	+8 lines, -12 lines	0 comments	Download
M	util/mach/exc_server_variants.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	util/mach/exc_server_variants.cc	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	util/mach/exc_server_variants_test.cc	View	3 chunks	+63 lines, -9 lines	0 comments	Download
M	util/mach/exception_ports_test.cc	View	1 chunk	+8 lines, -10 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years, 3 months ago (2014-09-17 21:59:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as b4fe6df (presubmit successful).