Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 566673003: ozone: events: Centralize & document our NativeEvent woes (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: events: Centralize & document our NativeEvent woes The "conversion" from NativeEvent to ui::Event logically belongs in the PlatformWindow, just prior to dispatch into aura. This is where the analogous process happens for other platforms such as X11. So do it there, using a helper function, and write a blurb about why we need to do this (short answer: for compatibility with existing code, while we working on fixing that code). BUG=none TEST=chrome --ozone-platform=caca, dri NOTRY=true Committed: https://crrev.com/25bd046f61399aa062cec49bbde50e1435202bca Cr-Commit-Position: refs/heads/master@{#294599}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -16 lines) Patch
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 chunk +1 line, -5 lines 0 comments Download
A ui/events/ozone/events_ozone.h View 1 chunk +39 lines, -0 lines 1 comment Download
M ui/events/ozone/events_ozone.cc View 3 chunks +37 lines, -2 lines 0 comments Download
M ui/ozone/platform/caca/caca_event_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/caca/caca_window.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years, 3 months ago (2014-09-11 20:04:44 UTC) #2
kpschoedel
LGTM https://codereview.chromium.org/566673003/diff/1/ui/events/ozone/events_ozone.h File ui/events/ozone/events_ozone.h (right): https://codereview.chromium.org/566673003/diff/1/ui/events/ozone/events_ozone.h#newcode28 ui/events/ozone/events_ozone.h:28: // "native" version of the event is unmodified. ...
6 years, 3 months ago (2014-09-11 21:23:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566673003/1
6 years, 3 months ago (2014-09-12 16:06:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as bb06109b864c2d4b6c11578c1bc338f36b61cb79
6 years, 3 months ago (2014-09-12 16:08:46 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 16:12:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25bd046f61399aa062cec49bbde50e1435202bca
Cr-Commit-Position: refs/heads/master@{#294599}

Powered by Google App Engine
This is Rietveld 408576698