[Android] JUnit test runner changes.

[Android] JUnit test runner changes.

BUG=316383
Committed: https://crrev.com/9a6b7b33b31a4023858b295ed290f95d3afa51f0
Cr-Commit-Position: refs/heads/master@{#295819}

[jbudorick, 2014-09-11 19:55:27]

jbudorick@chromium.org changed reviewers:
+ craigdh@chromium.org, klundberg@chromium.org

[jbudorick, 2014-09-11 19:55:27]

gyp and java changes will be in a separate review that I'll upload once
https://codereview.chromium.org/556893004/ lands.

[klundberg, 2014-09-11 20:25:13]

lgtm

https://codereview.chromium.org/566643002/diff/40001/build/android/pylib/juni...
File build/android/pylib/junit/test_runner.py (right):

https://codereview.chromium.org/566643002/diff/40001/build/android/pylib/juni...
build/android/pylib/junit/test_runner.py:12: """
nit: you can have """ on line 11

[jbudorick, 2014-09-11 20:33:54]

https://codereview.chromium.org/566643002/diff/40001/build/android/pylib/juni...
File build/android/pylib/junit/test_runner.py (right):

https://codereview.chromium.org/566643002/diff/40001/build/android/pylib/juni...
build/android/pylib/junit/test_runner.py:12: """
On 2014/09/11 20:25:13, klundberg wrote:
> nit: you can have """ on line 11

This is a very Frank-esque comment. :)

Cleaned up comments throughout the review.

[klundberg, 2014-09-11 21:24:20]

Still lgtm :-)

[jbudorick, 2014-09-19 15:33:21]

Hey Craig, can you take a look at this?

[craigdh, 2014-09-19 15:47:49]

lgtm w/ minor nit

https://codereview.chromium.org/566643002/diff/60001/build/android/pylib/juni...
File build/android/pylib/junit/test_dispatcher.py (right):

https://codereview.chromium.org/566643002/diff/60001/build/android/pylib/juni...
build/android/pylib/junit/test_dispatcher.py:18: return (None, 0 if all(map(run,
tests)) else 1)
Google style recommends just using list comprehensions instead of map. I tend to
agree.

[jbudorick, 2014-09-19 20:39:59]

https://codereview.chromium.org/566643002/diff/60001/build/android/pylib/juni...
File build/android/pylib/junit/test_dispatcher.py (right):

https://codereview.chromium.org/566643002/diff/60001/build/android/pylib/juni...
build/android/pylib/junit/test_dispatcher.py:18: return (None, 0 if all(map(run,
tests)) else 1)
On 2014/09/19 15:47:49, craigdh wrote:
> Google style recommends just using list comprehensions instead of map. I tend
to
> agree.

Switched to generator expression.

[jbudorick, 2014-09-19 20:40:14]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-09-19 20:41:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566643002/80001

[commit-bot: I haz the power, 2014-09-19 20:41:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566643002/80001

[jam, 2014-09-19 21:20:45]

The CQ bit was unchecked by jam@chromium.org

[jam, 2014-09-19 21:21:49]

On 2014/09/19 20:41:07, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/566643002/80001

sorry I unchecked the CQ here. this change made me realize we need to make
build/android cause tests to run. I had made android bots use analyze.py and as
a result the test run in the last patchset didn't run any tests. i'll do this
now

[jbudorick, 2014-09-19 21:24:05]

On 2014/09/19 21:21:49, jam wrote:
> On 2014/09/19 20:41:07, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/566643002/80001
> 
> sorry I unchecked the CQ here. this change made me realize we need to make
> build/android cause tests to run. I had made android bots use analyze.py and
as
> a result the test run in the last patchset didn't run any tests. i'll do this
> now

nbd, let me know when it's OK to re-CQ

[jam, 2014-09-19 21:39:23]

On 2014/09/19 21:24:05, jbudorick wrote:
> On 2014/09/19 21:21:49, jam wrote:
> > On 2014/09/19 20:41:07, I haz the power (commit-bot) wrote:
> > > CQ is trying da patch. Follow status at
> > >  https://chromium-cq-status.appspot.com/patch-status/566643002/80001
> > 
> > sorry I unchecked the CQ here. this change made me realize we need to make
> > build/android cause tests to run. I had made android bots use analyze.py and
> as
> > a result the test run in the last patchset didn't run any tests. i'll do
this
> > now
> 
> nbd, let me know when it's OK to re-CQ

sky just landed the fix in
https://crrev.com/e2caef887beee7c8cb3298461611d00044be4d73

[jam, 2014-09-19 21:39:31]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-19 21:40:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566643002/80001

[jam, 2014-09-19 21:43:56]

The CQ bit was unchecked by jam@chromium.org

[jam, 2014-09-19 21:44:25]

On 2014/09/19 21:39:23, jam wrote:
> On 2014/09/19 21:24:05, jbudorick wrote:
> > On 2014/09/19 21:21:49, jam wrote:
> > > On 2014/09/19 20:41:07, I haz the power (commit-bot) wrote:
> > > > CQ is trying da patch. Follow status at
> > > >  https://chromium-cq-status.appspot.com/patch-status/566643002/80001
> > > 
> > > sorry I unchecked the CQ here. this change made me realize we need to make
> > > build/android cause tests to run. I had made android bots use analyze.py
and
> > as
> > > a result the test run in the last patchset didn't run any tests. i'll do
> this
> > > now
> > 
> > nbd, let me know when it's OK to re-CQ
> 
> sky just landed the fix in
> https://crrev.com/e2caef887beee7c8cb3298461611d00044be4d73

ok you'll have to upload another patchset, otherwise the CQ will reuse the
faulty run that's already there. Sorry about that.

[jbudorick, 2014-09-19 22:22:03]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:23:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566643002/100001

[commit-bot: I haz the power, 2014-09-20 00:01:20]

Committed patchset #6 (id:100001) as de3a47dd72641c3a2d969031053ace43c20bbf85

[commit-bot: I haz the power, 2014-09-20 00:01:57]

Patchset 6 (id:??) landed as
https://crrev.com/9a6b7b33b31a4023858b295ed290f95d3afa51f0
Cr-Commit-Position: refs/heads/master@{#295819}