Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/sync/glue/sync_backend_host_core.h

Issue 566623003: Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - part 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More CR feedback addressed in DeviceInfoSyncService. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.h ('k') | chrome/browser/sync/glue/sync_backend_host_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/sync_backend_host_core.h
diff --git a/chrome/browser/sync/glue/sync_backend_host_core.h b/chrome/browser/sync/glue/sync_backend_host_core.h
index 5e61339a5d41ed79d10d80850845dac4d46dc2a3..46fb599e96bc4361854a049102df6ebcc8f98c28 100644
--- a/chrome/browser/sync/glue/sync_backend_host_core.h
+++ b/chrome/browser/sync/glue/sync_backend_host_core.h
@@ -40,8 +40,7 @@ struct DoInitializeOptions {
scoped_ptr<syncer::InternalComponentsFactory> internal_components_factory,
scoped_ptr<syncer::UnrecoverableErrorHandler> unrecoverable_error_handler,
syncer::ReportUnrecoverableErrorFunction
- report_unrecoverable_error_function,
- const std::string& signin_scoped_device_id);
+ report_unrecoverable_error_function);
~DoInitializeOptions();
base::MessageLoop* sync_loop;
@@ -64,7 +63,6 @@ struct DoInitializeOptions {
scoped_ptr<syncer::UnrecoverableErrorHandler> unrecoverable_error_handler;
syncer::ReportUnrecoverableErrorFunction
report_unrecoverable_error_function;
- std::string signin_scoped_device_id;
};
// Helper struct to handle currying params to
@@ -180,15 +178,9 @@ class SyncBackendHostCore
void OnControlTypesDownloadRetry();
// Called to perform tasks which require the control data to be downloaded.
- // This includes refreshing encryption, setting up the device info change
- // processor, etc.
+ // This includes refreshing encryption, etc.
void DoInitialProcessControlTypes();
- // Some parts of DoInitialProcessControlTypes() may be executed on a different
- // thread. This function asynchronously continues the work started in
- // DoInitialProcessControlTypes() once that other thread gets back to us.
- void DoFinishInitialProcessControlTypes();
-
// The shutdown order is a bit complicated:
// 1) Call ShutdownOnUIThread() from |frontend_loop_| to request sync manager
// to stop as soon as possible.
@@ -219,10 +211,6 @@ class SyncBackendHostCore
syncer::SyncManager* sync_manager() { return sync_manager_.get(); }
- SyncedDeviceTracker* synced_device_tracker() {
- return synced_device_tracker_.get();
- }
-
void SendBufferedProtocolEventsAndEnableForwarding();
void DisableProtocolEventForwarding();
@@ -293,9 +281,6 @@ class SyncBackendHostCore
// Our encryptor, which uses Chrome's encryption functions.
sync_driver::SystemEncryptor encryptor_;
- // A special ChangeProcessor that tracks the DEVICE_INFO type for us.
- scoped_ptr<SyncedDeviceTracker> synced_device_tracker_;
-
// The top-level syncapi entry point. Lives on the sync thread.
scoped_ptr<syncer::SyncManager> sync_manager_;
@@ -323,10 +308,6 @@ class SyncBackendHostCore
// Set when the forwarding of per-type debug counters is enabled.
bool forward_type_info_;
- // Obtained from SigninClient::GetSigninScopedDeviceId(). Stored here just to
- // pass from SyncBackendHostImpl to SyncedDeviceTracker.
- std::string signin_scoped_device_id_;
-
base::WeakPtrFactory<SyncBackendHostCore> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(SyncBackendHostCore);
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.h ('k') | chrome/browser/sync/glue/sync_backend_host_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698