chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h - Issue 566623003: Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h

Issue 566623003: Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - part 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More CR feedback addressed in DeviceInfoSyncService. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_apitest.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h

index c6f264390842f518ccf84017368d964d19e8bad8..774ca758ce10ac0329968fbe5149525bf1004afe 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h

@@ -13,6 +13,7 @@

namespace browser_sync {

class DeviceInfo;

+class DeviceInfoTracker;

} // namespace browser_sync

namespace extensions {

@@ -20,7 +21,6 @@ class ExtensionPrefs;

} // namespace extensions

class Profile;

-class ProfileSyncService;

namespace extensions {

@@ -34,7 +34,7 @@ ScopedVector<browser_sync::DeviceInfo> GetAllSignedInDevices(

ScopedVector<browser_sync::DeviceInfo> GetAllSignedInDevices(

const std::string& extension_id,

- ProfileSyncService* pss,

+ browser_sync::DeviceInfoTracker* device_tracker,

ExtensionPrefs* extension_prefs);

class SignedInDevicesGetFunction : public ChromeSyncExtensionFunction {