Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/sync/glue/local_device_info_provider_impl.cc

Issue 566623003: Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - part 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unit test fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/local_device_info_provider_impl.cc
diff --git a/chrome/browser/sync/glue/local_device_info_provider_impl.cc b/chrome/browser/sync/glue/local_device_info_provider_impl.cc
index 711e895ef25ba8c01c00158a0f11ee0aabff05c7..5e85737a213abee51c20cc8e5815117afed29fcb 100644
--- a/chrome/browser/sync/glue/local_device_info_provider_impl.cc
+++ b/chrome/browser/sync/glue/local_device_info_provider_impl.cc
@@ -42,17 +42,8 @@ void LocalDeviceInfoProviderImpl::Initialize(
void LocalDeviceInfoProviderImpl::InitializeContinuation(
const DeviceInfo& local_info) {
- // Copy constructor is disallowed in DeviceInfo, construct a new one from
- // the fields passed in local_info.
- local_device_info_.reset(
- new DeviceInfo(
- local_info.guid(),
- local_info.client_name(),
- local_info.chrome_version(),
- local_info.sync_user_agent(),
- local_info.device_type(),
- local_info.signin_scoped_device_id()));
-
+ // Make a copy of |local_info|.
+ local_device_info_.reset(local_info.Clone());
// Notify observers.
callback_list_.Notify();
}

Powered by Google App Engine
This is Rietveld 408576698