Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 566593002: Revert "Ensure that the browser’s copy of page id is in sync with the renderer’s." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 121b1406e329c5af180bb1066275373f84fc1d51..42707c47fa837ed4338190f5467796b0ecc890ef 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -11,14 +11,12 @@
#include "base/callback.h"
#include "base/command_line.h"
-#include "base/debug/crash_logging.h"
#include "base/debug/trace_event.h"
#include "base/i18n/rtl.h"
#include "base/json/json_reader.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/histogram.h"
#include "base/stl_util.h"
-#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/sys_info.h"
@@ -1090,13 +1088,6 @@ void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) {
}
void RenderViewHostImpl::OnUpdateState(int32 page_id, const PageState& state) {
- if (page_id_ != page_id) {
- base::debug::SetCrashKeyValue(
- "url1", GetMainFrame()->GetLastCommittedURL().possibly_invalid_spec());
- base::debug::SetCrashKeyValue("id1", base::IntToString(page_id_));
- base::debug::SetCrashKeyValue("id2", base::IntToString(page_id));
- CHECK(false);
- }
// Without this check, the renderer can trick the browser into using
// filenames it can't access in a future session restore.
if (!CanAccessFilesOfPageState(state)) {
@@ -1104,18 +1095,12 @@ void RenderViewHostImpl::OnUpdateState(int32 page_id, const PageState& state) {
return;
}
- delegate_->UpdateState(this, page_id_, state);
+ delegate_->UpdateState(this, page_id, state);
}
void RenderViewHostImpl::OnUpdateTargetURL(int32 page_id, const GURL& url) {
- if (page_id_ != page_id) {
- base::debug::SetCrashKeyValue("url1", url.possibly_invalid_spec());
- base::debug::SetCrashKeyValue("id1", base::IntToString(page_id_));
- base::debug::SetCrashKeyValue("id2", base::IntToString(page_id));
- CHECK(false);
- }
if (IsRVHStateActive(rvh_state_))
- delegate_->UpdateTargetURL(page_id_, url);
+ delegate_->UpdateTargetURL(page_id, url);
// Send a notification back to the renderer that we are ready to
// receive more target urls.
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698