Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 566583002: Do not use wide reads in CopyCharsUnsigned. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not use wide reads in CopyCharsUnsigned. R=jkummerow@chromium.org BUG=chromium:412967 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=23876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M src/utils.h View 1 chunk +4 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 3 months ago (2014-09-11 12:48:03 UTC) #1
Jakob Kummerow
LGTM. Consider LOG=y since this is change affects embedders wanting to use GCC 4.9.
6 years, 3 months ago (2014-09-11 12:49:32 UTC) #2
Yang
On 2014/09/11 12:49:32, Jakob wrote: > LGTM. > > Consider LOG=y since this is change ...
6 years, 3 months ago (2014-09-11 12:50:51 UTC) #3
Yang
6 years, 3 months ago (2014-09-11 12:51:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698