Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/themes/theme_service.h

Issue 566573004: Remove deprecated extension notification from themeservice. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unittest failed Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_service.h
diff --git a/chrome/browser/themes/theme_service.h b/chrome/browser/themes/theme_service.h
index b70fd74c3cdb19ec7b8f273e11b1dbbd4532cba1..40df22bc351ed9f478c4f42c100fad741996ec22 100644
--- a/chrome/browser/themes/theme_service.h
+++ b/chrome/browser/themes/theme_service.h
@@ -18,6 +18,7 @@
#include "components/keyed_service/core/keyed_service.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+#include "extensions/browser/extension_registry_observer.h"
#include "ui/base/theme_provider.h"
class CustomThemeSupplier;
@@ -35,6 +36,7 @@ struct HSL;
namespace extensions {
class Extension;
+class ExtensionRegistry;
}
namespace gfx {
@@ -58,6 +60,7 @@ extern "C" NSString* const kBrowserThemeDidChangeNotification;
class ThemeService : public base::NonThreadSafe,
public content::NotificationObserver,
+ public extensions::ExtensionRegistryObserver,
public KeyedService,
public ui::ThemeProvider {
public:
@@ -97,6 +100,24 @@ class ThemeService : public base::NonThreadSafe,
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
+ // extensions::ExtensionRegistryObserver:
+ void OnExtensionLoaded(
+ content::BrowserContext* browser_context,
+ const extensions::Extension* extension) override;
+ void OnExtensionUnloaded(
+ content::BrowserContext* browser_context,
+ const extensions::Extension* extension,
+ extensions::UnloadedExtensionInfo::Reason reason) override;
+ void OnExtensionWillBeInstalled(
+ content::BrowserContext* browser_context,
+ const extensions::Extension* extension,
+ bool is_update,
+ bool from_ephemeral,
+ const std::string& old_name) override;
+
+ // KeyedService:
+ void Shutdown() override;
+
// Set the current theme to the theme defined in |extension|.
// |extension| must already be added to this profile's
// ExtensionService.
@@ -246,6 +267,8 @@ class ThemeService : public base::NonThreadSafe,
content::NotificationRegistrar registrar_;
+ extensions::ExtensionRegistry* extension_registry_;
+
scoped_ptr<ThemeSyncableService> theme_syncable_service_;
base::WeakPtrFactory<ThemeService> weak_ptr_factory_;
« no previous file with comments | « no previous file | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698