Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 566543002: Skip long running test variants for NaCL. (Closed)

Created:
6 years, 3 months ago by ulan
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne, svenpanne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Skip long running test variants for NaCL. BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23870

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +12 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
ulan
PTAL
6 years, 3 months ago (2014-09-11 11:17:05 UTC) #2
Sven Panne
LGTM with a nit https://codereview.chromium.org/566543002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/566543002/diff/1/test/mjsunit/mjsunit.status#newcode538 test/mjsunit/mjsunit.status:538: # Skip tests that timout ...
6 years, 3 months ago (2014-09-11 11:30:05 UTC) #4
ulan
6 years, 3 months ago (2014-09-11 11:49:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698