mac: Make the avatar button layer backed.

chrome/browser/ui/cocoa/browser_window_controller_private.h

Index: chrome/browser/ui/cocoa/browser_window_controller_private.h
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.h b/chrome/browser/ui/cocoa/browser_window_controller_private.h
index c4c57a17366b31c92dd350733c1325aa17e66737..a97785d10863160cb4f3f330f29820269d239a16 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.h
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.h
@@ -137,6 +137,14 @@
 // The opacity for the toolbar divider; 0 means that it shouldn't be shown.
 - (CGFloat)toolbarDividerOpacity;
 
+// When a view does not have a layer, but it has multiple subviews with layers,
+// the ordering of the layers is not well defined. Removing a subview and
+// re-adding it to the same position has the side effect of updating the layer
+// ordering to better reflect the subview ordering.
+// This is a hack needed because NSThemeFrame is not layer backed, but it has
+// multiple direct subviews which are. http://crbug.com/413009
+- (void)toggleLayerOrdering:(NSView*)view;

[Avi (use Gerrit), 2014/09/12 05:58:17]

"toggle" means to switch between two settings. This isn't toggling.

-updateLayerOrdering: perhaps? (Straight from your comment.)

And yes, I'm cringing.

[erikchen, 2014/09/12 17:29:55]

Done.

+
 // Ensures the z-order of subviews is correct.
 - (void)updateSubviewZOrder:(BOOL)inPresentationMode;