Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 566463003: Removes redundant test (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removes redundant test After changes that made Embed() always create a new connection this test is now redundant with EmbedWithSameViewId*. Additionally it wasn't properly waiting, leading to use after frees. BUG=none TEST=covered by tests R=aa@chromium.org Committed: https://crrev.com/b546ca9a2f80dcf22412d47102bb37d59c8d034d Cr-Commit-Position: refs/heads/master@{#294648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +7 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sky
6 years, 3 months ago (2014-09-12 04:19:09 UTC) #1
Aaron Boodman
lgtm
6 years, 3 months ago (2014-09-12 15:49:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566463003/1
6 years, 3 months ago (2014-09-12 15:53:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/15735)
6 years, 3 months ago (2014-09-12 16:39:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566463003/1
6 years, 3 months ago (2014-09-12 19:59:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as fa2ec43b2873cd01a79015eefa2871fca2a1dc06
6 years, 3 months ago (2014-09-12 20:29:28 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 20:37:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b546ca9a2f80dcf22412d47102bb37d59c8d034d
Cr-Commit-Position: refs/heads/master@{#294648}

Powered by Google App Engine
This is Rietveld 408576698