Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 566463002: Ensure that v8 arrays are always converted to object vars when allowed. (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure that v8 arrays are always converted to object vars when allowed. To maintain synchronous scripting backward compatibility, v8 arrays should always be converted to object vars when allowed. I have added a comment explaining the conversion of objects in more detail. This CL also adds a check to ensure that when we convert an object var to a v8 value that it is never nested inside of an array or dictionary. Before we switched from NPObject to gin, this was never possible so there is no need to add this functionality now and we should restrict this case from ever happening. BUG=411445 Committed: https://crrev.com/b918671e294f8ce830b5cb35ec09ecac95d3565a Cr-Commit-Position: refs/heads/master@{#294785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M content/renderer/pepper/v8_var_converter.cc View 3 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
raymes
6 years, 3 months ago (2014-09-11 01:18:29 UTC) #2
yzshen1
LGTM (David: Raymes pinged me since it seems you don't have time today.)
6 years, 3 months ago (2014-09-12 00:02:07 UTC) #4
dmichael (off chromium)
lgtm, sorry I missed this yesterday
6 years, 3 months ago (2014-09-12 18:59:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566463002/1
6 years, 3 months ago (2014-09-15 03:23:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6dff5feb86f43f56ac986cb6b6f9e6ee496235b8
6 years, 3 months ago (2014-09-15 04:42:03 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 04:47:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b918671e294f8ce830b5cb35ec09ecac95d3565a
Cr-Commit-Position: refs/heads/master@{#294785}

Powered by Google App Engine
This is Rietveld 408576698