Don't clip invalidation of composited scrolling contents

Don't clip invalidation of composited scrolling contents

The compositor expects that the whole composited scrolling layer to be
invalidated in time and won't update the tiles that are newly visible
when scrolled if the tiles are up-to-date from the compositor side.

If we clip invalidations, the compositor will think the layer areas
outside of the clip are all valid and won't repaint them.

BUG=412516
TEST=compositing/repaint/should-not-clip-composited-viewport-scrolling-layer.html
TEST=compositing/repaint/should-not-clip-composited-overflow-scrolling-layer.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181873

[Xianzhu, 2014-09-10 23:45:13]

wangxianzhu@chromium.org changed reviewers:
+ dsinclair@chromium.org, jchaffraix@chromium.org, leviw@chromium.org

[Xianzhu, 2014-09-10 23:45:14]

https://codereview.chromium.org/566433002/diff/1/LayoutTests/compositing/repa...
File
LayoutTests/compositing/repaint/should-not-clip-composited-scrolling-layer2-expected.txt
(right):

https://codereview.chromium.org/566433002/diff/1/LayoutTests/compositing/repa...
LayoutTests/compositing/repaint/should-not-clip-composited-scrolling-layer2-expected.txt:15:
[0, 0, 500, 500]
This is not fully correct that both the container and and contents layer are
invalidated. Will fix it later.

https://codereview.chromium.org/566433002/diff/1/LayoutTests/compositing/repa...
LayoutTests/compositing/repaint/should-not-clip-composited-scrolling-layer2-expected.txt:26:
[2000, 2000, 3000, 3000],
This is because of the previousPaintInvalidationRect. Will fix it later.

[Xianzhu, 2014-09-11 21:29:22]

ping...

[Julien - ping for review, 2014-09-11 22:06:47]

lgtm but let's change the tests' name to be better (I don't like 1 and 2, if
they were the testing the exact same condition, why include 2 tests?).

[Xianzhu, 2014-09-11 22:11:01]

On 2014/09/11 22:06:47, Julien Chaffraix - PST wrote:
> lgtm but let's change the tests' name to be better (I don't like 1 and 2, if
> they were the testing the exact same condition, why include 2 tests?).

Will change them to:
  should-not-clip-composited-viewport-scrolling-layer.html
and
  should-not-clip-composited-overflow-scrolling-layer.html

[Xianzhu, 2014-09-11 22:15:53]

On 2014/09/11 22:11:01, Xianzhu wrote:
> On 2014/09/11 22:06:47, Julien Chaffraix - PST wrote:
> > lgtm but let's change the tests' name to be better (I don't like 1 and 2, if
> > they were the testing the exact same condition, why include 2 tests?).
> 
> Will change them to:
>   should-not-clip-composited-viewport-scrolling-layer.html
> and
>   should-not-clip-composited-overflow-scrolling-layer.html

Done.

[Xianzhu, 2014-09-11 22:16:01]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-09-11 22:16:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566433002/40001

[commit-bot: I haz the power, 2014-09-12 01:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 01:18:05]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/23091)

[Xianzhu, 2014-09-12 02:32:20]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-09-12 02:32:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566433002/80001

[commit-bot: I haz the power, 2014-09-12 03:37:32]

Committed patchset #5 (id:80001) as 181873