Issue 56643002: Add icon for Now component extension (to appear in Notification settings dialog)

Issue 56643002: Add icon for Now component extension (to appear in Notification settings dialog) (Closed)

Created:
7 years, 1 month ago by skare_

Modified:
7 years, 1 month ago

Reviewers:
robliao, vadimt, dgozman

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add icon for Now component extension (to appear in Notification settings dialog) BUG=229653 R=dgozman@chromium.org, robliao@chromium.org, vadimt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232844

Patch Set 1 #

Patch Set 2 : re-enable icons in manifest #

Patch Set 3 : (add bug id) #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
M	chrome/browser/resources/component_extension_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/google_now/images/icon128.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/google_now/images/icon16.png	View		Binary file		0 comments	Download
A	chrome/browser/resources/google_now/images/icon48.png	View		Binary file		0 comments	Download
M	chrome/browser/resources/google_now/manifest.json	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

skare_

+dgozman for OWNERS of chrome/browser/resources/component_extension_resources.grd

7 years, 1 month ago (2013-11-02 00:05:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skare@chromium.org/56643002/110001

7 years, 1 month ago (2013-11-04 17:59:58 UTC) #5

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218690

7 years, 1 month ago (2013-11-04 21:15:51 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skare@chromium.org/56643002/110001

7 years, 1 month ago (2013-11-04 21:19:20 UTC) #7

robliao

7 years, 1 month ago (2013-11-05 00:15:23 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r232844 (presubmit successful).

Expand Messages | Collapse Messages