Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 566423002: Disable repeated signin as manager. (Closed)

Created:
6 years, 3 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable repeated signin as manager. BUG=407853 R=nkostylev@chromium.org Committed: https://crrev.com/eb36e3657aa674ee8928bd1888f53d6d11783a27 Cr-Commit-Position: refs/heads/master@{#295069}

Patch Set 1 #

Patch Set 2 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 5 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Denis Kuznetsov (DE-MUC)
6 years, 3 months ago (2014-09-15 18:08:30 UTC) #1
Nikita (slow)
lgtm But please double check that all UI elements are blocked during sign in as ...
6 years, 3 months ago (2014-09-15 18:22:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566423002/1
6 years, 3 months ago (2014-09-16 10:02:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56459)
6 years, 3 months ago (2014-09-16 10:05:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566423002/20001
6 years, 3 months ago (2014-09-16 14:14:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c17eed2d8b86bcf9c80ab42f96016543fb7cabc1
6 years, 3 months ago (2014-09-16 15:10:30 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:12:26 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eb36e3657aa674ee8928bd1888f53d6d11783a27
Cr-Commit-Position: refs/heads/master@{#295069}

Powered by Google App Engine
This is Rietveld 408576698