Issue 566413002: Remove dependencies of chrome in web_request_api_helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 566413002: Remove dependencies of chrome in web_request_api_helper. (Closed)

Created:
6 years, 3 months ago by Xi Han

Modified:
6 years, 3 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg, Fady Samuel

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove dependencies on profile and ProfileManager of chrome. BUG=352293 Committed: https://crrev.com/1ad1d98389d4e3ab1bcdc3a3d73d57f559102212 Cr-Commit-Position: refs/heads/master@{#294942}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	chrome/browser/extensions/api/web_request/web_request_api_helpers.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/extensions/api/web_request/web_request_api_helpers.cc	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566413002/1

6 years, 3 months ago (2014-09-15 22:40:07 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 26ec64f17f4a2c01adf43e6cfc40250c0dd42066

6 years, 3 months ago (2014-09-16 00:33:22 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 00:40:06 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1ad1d98389d4e3ab1bcdc3a3d73d57f559102212
Cr-Commit-Position: refs/heads/master@{#294942}